Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validates client config new #1114

Conversation

atomicgamedeveloper
Copy link
Contributor

Copied from previous PR #1083:

Title

Validates client config.

Fixes #658

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Description

This PR will provide a route to validate the client config file. A comprehensive, manual one for developers, and another one that automatically redirects users in case their config is incorrectly setup or URLs are unreachable.
It will also update the client dependencies. Related to issue #658.

Testing

Manual testing for now.

Impact

  • Zod dependency.
  • Once complete, the website access flow will be different if your config is wrong.
  • LayoutPublic is parameterized with a possible Breakpoint instead of always being 'xs'.
  • Additional route of '/verify'

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have added tests for all the new code and any changes made to
    existing code.
  • I have made corresponding changes to the documentation.

@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper please add the changes on your fearure/distributed-demo and make a PR from there. Thanks.

@atomicgamedeveloper
Copy link
Contributor Author

@atomicgamedeveloper please add the changes on your fearure/distributed-demo and make a PR from there. Thanks.

I don't follow, sorry. Could you please elaborate?

@prasadtalasila
Copy link
Contributor

prasadtalasila commented Dec 18, 2024

@atomicgamedeveloper please follow these steps:

  1. Force push your 658-validate-client-config-2 to your feature/distributed-demo branch
  2. Open a new PR from your feature/distributed-demo branch to feature/distributed-demo branch of https://github.com/INTO-CPS-Association/DTaaS

Is it clear now?

@atomicgamedeveloper
Copy link
Contributor Author

@atomicgamedeveloper please add the changes on your fearure/distributed-demo and make a PR from there. Thanks.

I am not sure that I understand.

@atomicgamedeveloper please follow these steps:

1. Force push your `658-validate-client-config-2` to your `feature/distributed-demo` branch

2. Open a new PR from your `feature/distributed-demo` branch to `feature/distributed-demo` branch of https://github.com/INTO-CPS-Association/DTaaS

Is it clear now?

Yes, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate react website configuration
2 participants